fix: hide 'trashed' subscriptions from My Account #4351

laurelfulford · 2025-12-09T23:31:18Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR hides trashed subscriptions from the My Account view.

If you only have trashed subscriptions, it hides the Subscriptions menu all together.

See: NPPM-2442

How to test the changes in this Pull Request:

Start on a test site with RAS set up
Set up a subscription product that can be purchased multiple times by the same reader (just to make testing easier), and add a Checkout button block
In an incognito window, run through a purchase of your subscription with the credit card 4000 0000 0000 0341 (which will result in a failed payment).
After the transaction fails, go to 'My Account', and note the trash sub:

Apply this PR and run npm run build.
In the incognito window, refresh the page; confirm you don't have any subscriptions listed, and there isn't a Subscription menu item (so the typical reader wouldn't get to this screen).

Go back and try to buy the subscription again, this time using a successful test card.
Go back to My Account, and confirm you have a single My Subscription; when you click on it it should show your one subscription details:

Purchase a second subscription and confirm you get the Subscriptions menu item with a list as the top level in My Account, and that only non-trashed subs are shown (you can also mess with the subscriptions, cancelling them, etc.). All of them should show, unless they are trashed:

Lastly, as the admin manually trash all but one subscription and make sure you're back to the view in step 8 (if you just refresh the /subscriptions page as the user, you'll still see the list with one item, but the navigation should say My Subscription and just go to the remaining non-trashed one).

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

miguelpeixe

This tested well, but I think we can go for a simpler approach. The user subscription list and "Subscriptions/My Subscription" button rely on wcs_get_users_subscriptions(), which supports a hook.

Something like this should be enough:

add_filter(
	'wcs_get_users_subscriptions',
	function( $subscriptions ) {
		if ( function_exists( 'is_account_page' ) && is_account_page() ) {
			$subscriptions = array_filter(
				$subscriptions,
				function( $subscription ) {
					return ! $subscription->has_status( 'trash' );
				}
			);
		}
		return $subscriptions;
	},
	10
);

laurelfulford · 2025-12-12T22:20:28Z

Oh, that's so much nicer - thanks @miguelpeixe! 🙌

I left a couple pieces of the original code in:

I noticed when you just had My Subscription in the menu it didn't highlight when you clicked on it, so that's been fixed
I tweaked the styles of buttons when they're in notices to just look like regular links - they were displaying full size before and sticking out of the bottom. I only saw this kind of message + button when I visited /my-account/subscriptions/ when no subscriptions were actually showing - a reader's not going to get to that but it was bugging me 😆

miguelpeixe

Thank you for revising! 🙌

github-actions · 2025-12-15T18:06:42Z

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

# [6.29.0-alpha.1](v6.28.0...v6.29.0-alpha.1) (2026-01-09) ### Bug Fixes * add default reader meta ([#4360](#4360)) ([01564ad](01564ad)) * **ads:** placement control value reset ([#4375](#4375)) ([72d7b68](72d7b68)) * **autocomplete:** improve value parsing in AutocompleteTokenField and ListsControl components ([#4376](#4376)) ([84e388d](84e388d)) * clarify the media credit placeholder image's labelling ([#4352](#4352)) ([4420b65](4420b65)) * **content-gating:** stop running `restrict_post` after gate is rendered ([#4368](#4368)) ([8489a6c](8489a6c)) * fallback password reset URL ([#4382](#4382)) ([06d1503](06d1503)) * hide 'trashed' subscriptions from My Account ([#4351](#4351)) ([e759378](e759378)) * **my-account:** top position on desktop ([#4355](#4355)) ([1b3255a](1b3255a)) * prevent doubled URL in reader registration block magic link ([#4379](#4379)) ([ba4d855](ba4d855)) * remove newspack-ui CSS class from my account when not logged in ([#4384](#4384)) ([2bb8630](2bb8630)) * remove space if no time ([#4380](#4380)) ([05c57e9](05c57e9)) * select specific product for content gifting and countdown banners ([#4366](#4366)) ([809c230](809c230)) * **sso:** change Jetpack configuration notice from error to warning ([#4383](#4383)) ([e5e0643](e5e0643)) * **subscriptions:** remove actions from gifted subscription ([#4362](#4362)) ([8fbc243](8fbc243)) * **update-payment-notice:** don't render on checkout ([#4356](#4356)) ([dd80c06](dd80c06)) ### Features * Add Managed Nextdoor Auth ([#4359](#4359)) ([fee2480](fee2480)) * add media credits to RSS feeds ([#4357](#4357)) ([e638447](e638447)) * **content-gating:** add Content Gate settings page ([#4363](#4363)) ([822c363](822c363)) * **content-gating:** enable content rule exclusions ([#4346](#4346)) ([1e5718b](1e5718b)) * **content-gating:** update content gates UI ([#4345](#4345)) ([4e22075](4e22075)) * rename newsletter tracking ([#4358](#4358)) ([3da6434](3da6434)) * **web-preview:** add ESC key support and dynamic titles for segments and prompts ([#4294](#4294)) ([7238d2f](7238d2f))

matticbot · 2026-01-09T15:21:00Z

🎉 This PR is included in version 6.29.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [6.29.0](v6.28.2...v6.29.0) (2026-01-19) ### Bug Fixes * add default reader meta ([#4360](#4360)) ([01564ad](01564ad)) * **ads:** placement control value reset ([#4375](#4375)) ([72d7b68](72d7b68)) * **autocomplete:** improve value parsing in AutocompleteTokenField and ListsControl components ([#4376](#4376)) ([84e388d](84e388d)) * clarify the media credit placeholder image's labelling ([#4352](#4352)) ([4420b65](4420b65)) * **content-gating:** stop running `restrict_post` after gate is rendered ([#4368](#4368)) ([8489a6c](8489a6c)) * fallback password reset URL ([#4382](#4382)) ([06d1503](06d1503)) * hide 'trashed' subscriptions from My Account ([#4351](#4351)) ([e759378](e759378)) * **my-account:** top position on desktop ([#4355](#4355)) ([1b3255a](1b3255a)) * prevent doubled URL in reader registration block magic link ([#4379](#4379)) ([ba4d855](ba4d855)) * remove newspack-ui CSS class from my account when not logged in ([#4384](#4384)) ([2bb8630](2bb8630)) * remove space if no time ([#4380](#4380)) ([05c57e9](05c57e9)) * select specific product for content gifting and countdown banners ([#4366](#4366)) ([809c230](809c230)) * **sso:** change Jetpack configuration notice from error to warning ([#4383](#4383)) ([e5e0643](e5e0643)) * **subscriptions:** remove actions from gifted subscription ([#4362](#4362)) ([8fbc243](8fbc243)) * **update-payment-notice:** don't render on checkout ([#4356](#4356)) ([dd80c06](dd80c06)) ### Features * Add Managed Nextdoor Auth ([#4359](#4359)) ([fee2480](fee2480)) * add media credits to RSS feeds ([#4357](#4357)) ([e638447](e638447)) * **content-gating:** add Content Gate settings page ([#4363](#4363)) ([822c363](822c363)) * **content-gating:** enable content rule exclusions ([#4346](#4346)) ([1e5718b](1e5718b)) * **content-gating:** update content gates UI ([#4345](#4345)) ([4e22075](4e22075)) * rename newsletter tracking ([#4358](#4358)) ([3da6434](3da6434)) * **web-preview:** add ESC key support and dynamic titles for segments and prompts ([#4294](#4294)) ([7238d2f](7238d2f))

matticbot · 2026-01-19T17:24:44Z

🎉 This PR is included in version 6.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

laurelfulford added 4 commits December 8, 2025 15:18

fix: remove subscriptions from table with the status 'trash'

f12e4c7

fix: update My Account menu to reflect number of visible subscriptions

6566c6b

fix: make sure My Subscription is highlighted when viewing subscription

ceee68f

fix: correct notice button styles

13941ce

laurelfulford requested a review from a team as a code owner December 9, 2025 23:31

laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 9, 2025

laurelfulford changed the title ~~Fix/hide trashed subscriptions~~ fix: hide 'trashed' subscriptions from My Account Dec 9, 2025

miguelpeixe self-requested a review December 12, 2025 14:18

miguelpeixe requested changes Dec 12, 2025

View reviewed changes

github-actions bot added the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Dec 12, 2025

fix: streamline PR based on feedback

ed9548b

laurelfulford requested a review from miguelpeixe December 12, 2025 22:20

miguelpeixe approved these changes Dec 15, 2025

View reviewed changes

github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator labels Dec 15, 2025

laurelfulford merged commit e759378 into trunk Dec 15, 2025
8 checks passed

laurelfulford deleted the fix/hide-trashed-subscriptions branch December 15, 2025 18:06

github-actions bot added the needs-changelog label Dec 15, 2025

laurelfulford removed the needs-changelog label Dec 16, 2025

matticbot added the released on @alpha label Jan 9, 2026

matticbot added the released label Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: hide 'trashed' subscriptions from My Account #4351

fix: hide 'trashed' subscriptions from My Account #4351

laurelfulford commented Dec 9, 2025

Uh oh!

miguelpeixe left a comment

Uh oh!

laurelfulford commented Dec 12, 2025

Uh oh!

miguelpeixe left a comment

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

matticbot commented Jan 9, 2026

Uh oh!

matticbot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: hide 'trashed' subscriptions from My Account #4351

fix: hide 'trashed' subscriptions from My Account #4351

Conversation

laurelfulford commented Dec 9, 2025

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

laurelfulford commented Dec 12, 2025

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

matticbot commented Jan 9, 2026

Uh oh!

matticbot commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants